New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong code gen (map) #13

Closed

franziskuskiefer opened this issue May 27, 2024 · 1 comment

Collaborator

franziskuskiefer commented May 27, 2024 •

edited

Loading

Two places with invalid code gen (that may or may not be related).
The diff in hacl-packages has manual fixes to the C code.

The code here

https://github.com/cryspen/libcrux/blob/66c2e554124e9e802ad99e724bb4e4da4f606dbf/libcrux-ml-kem/src/sampling.rs#L74-L104

gets compiled to

cryspen/hacl-packages@e19a237#diff-0d8e4e786b25ff53506ee2584cdcf17926c6b18ee67d3c7a88405d7d7746db1cR7768-R7777

The map at the end is not compiled right.

Similarly,

https://github.com/cryspen/libcrux/blob/66c2e554124e9e802ad99e724bb4e4da4f606dbf/libcrux-ml-kem/src/polynomial.rs#L34-L40

gets compiled to

cryspen/hacl-packages@9fb519d#diff-0d8e4e786b25ff53506ee2584cdcf17926c6b18ee67d3c7a88405d7d7746db1cR2456-R2461

The text was updated successfully, but these errors were encountered:

msprotz added a commit that referenced this issue


          This perhaps fixes #13

19ddd07

Contributor

msprotz commented May 31, 2024

This is now fixed since mlkem works.

msprotz closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment