Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on upstream fixes to disable systematic desugaring of array assi… #5

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

msprotz
Copy link
Contributor

@msprotz msprotz commented Feb 13, 2024

…gnments, which in turn leads to much prettier code-gen.

…gnments, which in turn leads to much prettier code-gen.
@msprotz
Copy link
Contributor Author

msprotz commented Feb 13, 2024

@W95Psp is this using the latest krml master? it looks like this build hasn't picked up my upstream fixes... thanks!!

@W95Psp
Copy link
Collaborator

W95Psp commented Feb 13, 2024

hi @msprotz, indeed, dependencies are all pinned and locked!
I pushed an update.

If you have Nix installed, you can nix flake update to update every dependencies, and then commit the flake.lock file.
(or nix flake lock --update-input INPUT to update an input INPUT, with INPUT being a key of inputs in flake.nix)

@msprotz
Copy link
Contributor Author

msprotz commented Feb 13, 2024

Thanks! That already allowed me to uncover another issue.

Is there a way to always pick the latest version available? Pinning a version of Charon has little value for me. For me, the main appeal of CI is being notified as soon as Charon changes something upstream so that I can catch up.

@msprotz msprotz merged commit 5820d55 into main Feb 13, 2024
2 checks passed
@msprotz msprotz deleted the protz_initializers branch February 13, 2024 18:02
@W95Psp
Copy link
Collaborator

W95Psp commented Feb 13, 2024

The nightly job is picking the latest version of everything actually!
so if anything goes wrong with new Charon/Krml/F*/whatever, the nighlty job will fail

This PR/push job is testing against pinned dependencies, we can change that, but it is a bit weird with respect to the lockfile

@msprotz
Copy link
Contributor Author

msprotz commented Feb 13, 2024

Ah ok perfect! I didn't realize that was the purpose of the nightly. Sounds great then. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants