Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another core_array_equality to eurydice_glue.h #61

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

franziskuskiefer
Copy link
Collaborator

Add another core_array_equality function.

Add another `core_array_equality` function.
@msprotz
Copy link
Contributor

msprotz commented Aug 27, 2024

Cool, confirm that a1 and a2 are arrays, not slices? From the name it looks like the arguments may be slices.

@franziskuskiefer
Copy link
Collaborator Author

Ha good catch. It's indeed a slice. I'll update later.

Copy link
Contributor

@msprotz msprotz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's better, but t* is not going to work if t is a non-scalar type, e.g. the "pointerized" version of int[2] is (int*)[2], not int[2]*.

Do you need that cast here? If so, we need custom support for this in code-gen (which I'm happy to implement).

@msprotz msprotz merged commit 31be7d6 into main Aug 28, 2024
4 checks passed
@msprotz msprotz deleted the franziskus/more-array-equal-glue branch August 28, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants