Replace the internal Fibonacci heap with a 4-ary priority queue #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the current heap implementation with one written by François Pacull. Change the Dijkstra's implementation to make use of this new heap. Originally written by François Pacull. Co-authored-by: djfrancesco <pacullfrancois@gmail.com> Co-authored-by: chrisobi02 <chrisgobrien02@gmail.com>
jamiecook
reviewed
Jan 10, 2023
changed the email address
organization name
djfrancesco
approved these changes
Jan 10, 2023
Opt for pandas testing over manual assertions. New reference files are required because the new heap finds equivalent but different paths.
djfrancesco
approved these changes
Jan 11, 2023
pedrocamargo
approved these changes
Jan 12, 2023
|
For reference. Image created by @chrisobi02 |
|
Congrats to @Jake-Moss , @chrisobi02 & @djfrancesco for the amazing work that went into this PR!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides up to a 3.5x performance increase on the various models tested.
It also changes the default behaviour of
memory_onlymode to default toTrue, enables theNPY_NO_DEPRECATED_APIandNPY_1_7_API_VERSIONmacros for Unix builds, and restores thelanguage_levelto3for Cython.The heap implementation were written by @djfrancesco and has the MIT license preserved as a header in the
pq_4ary_heap.pyxfile.