-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
S&F transit graph creation #420
Merged
djfrancesco
merged 100 commits into
AequilibraE:feature_PuT_assignment
from
djfrancesco:feature_PuT_assignment
Sep 6, 2023
Merged
S&F transit graph creation #420
djfrancesco
merged 100 commits into
AequilibraE:feature_PuT_assignment
from
djfrancesco:feature_PuT_assignment
Sep 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oarding vertices dataframe
Co-authored-by: pveigadecamargo <pveigadecamargo@anl.gov>
Add create_od_vertices()
Add creation of connector edges
Usage: ```python graph = SF_graph_builder(pt_con, prj_con) graph.create_vertices() graph.create_edges() graph.create_additional_db_fields() graph.save_vertices() graph.save_edges() ``` Caveats are noted in the comments of the functions.
Allows the whole graph to be read back into aequilibrae
We know use WKB format consistently and only convert out when need. String manipulation and regexs have also been replaced. type -> node_type, link_type head_vert_id -> a_node tail_vert_id -> b_node coord -> geometry vert_id -> node_id edge_id -> link_id
…aE#438) * Prevent invalid attribute names on AequilibraE data fields This previously would have resulted in syntax error when accessing but its best we don't accept them anyway. * Fix multiple classes not being presented in the returned df Bug report: https://groups.google.com/g/aequilibrae/c/y_q9nLNs6-Y/m/yWXNpey9AAAJ * Style * Skip if network fails * Rounding * fixes test * Revert "Rounding" Vatican City really did move huh This reverts commit d9d0a5d. --------- Co-authored-by: pveigadecamargo <pveigadecamargo@anl.gov>
Includes files copied from network triggers with slight modifications Need to remove unnecessary columns from links and nodes tables. Zones are still saved to project db and also need to be migrated.
With the release of Cython 3.0.0 there are a few changes of note to use. Particularly the performance impact of the removal of the implicit noexcept. Now all cdefs allow exceptions by default meaning every cdef must require the gil at the end of the function regardless of whether it was nogil or not. Adding the noexcept clause reverts to the old behaviour. There is a compiler directive to result this old behaviour but better be be explicit when the solution is one regex away: `^(cp?def(?:.|\n).*?)(nogil|):$` https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html#exception-values-and-noexcept
…ture_PuT_assignment
Add preliminary db saving
…librae into feature_PuT_assignment
…librae into feature_PuT_assignment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load these elements from the transit database:
We also need to load a list of zones:
Now create the graph vertices:
And the graph edges:
Add model parameters:
Add specific transport mode on-board time factors: funicular, subway, tram, bus, hls_bus, train, boat,...