Fix : Load Region Model Correctly #134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If region Id exist the model should be loaded by ->load() method instead of loadByCode().
|
is there any update ? @kkong87 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If region Id exist the model should be loaded by ->load() method instead of loadByCode().
name: Load Region Model Correctly
Description
Load Region Model Correctly
How To Reproduce
Steps to reproduce the behavior:
I discovered this issue after installing this module. After this module installed new order mails are could not been sent.
And got this exception log
[2024-08-29T12:14:58.711410+00:00] .CRITICAL: Error: Object of class Magento\Directory\Model\Region could not be converted to string in /home/magento/vendor/magento/module-directory/Model/ResourceModel/Region.php:143 Stack trace: #0 /home/magento/vendor/magento/module-directory/Model/Region.php(59): Magento\Directory\Model\ResourceModel\Region->loadByCode() #1 /home/magento/vendor/affirm/magento2/Model/Observer/AddressFormat.php(48): Magento\Directory\Model\Region->loadByCode()Then I discovered this bug in code.
Expected behavior
If the region name was missing should be filled correctly via this observer
Screenshots
Benefits
Fixes the issue
Additional information