Support categories #152
Support categories #152
Conversation
AffirmSDK/AffirmItem.h
Outdated
| unitPrice:(NSDecimalNumber *)unitPrice | ||
| quantity:(NSInteger)quantity | ||
| URL:(NSURL *)URL | ||
| categories:(nullable NSArray<NSArray<NSString *> *> *)categories |
There was a problem hiding this comment.
I'm coming into this cold and don't have context. But an array of arrays is kind of weird to wrap one's head around.
Would it be clearer to define an AffirmCategory like:
@interface AffirmCategory
@property (nonatomic, nonnull) NSString name;
@property (nonatomic, nullable) NSArray<NSString*> subCategories;
... etc.and have categories be an NSArray<AffirmCategory*>*?
There was a problem hiding this comment.
Right now, both the backend and Android SDK use a two-dimensional string array without any subdivisions. Do we need to standardize this? If we decide to define an AffirmCategory, it only needs to include an array, the name isn't really necessary.
Backend:
https://docs.affirm.com/developers/reference/the-item-object
There was a problem hiding this comment.
Due to some issues with GitHub Actions on the latest macOS, downgrading to macOS-12 can resolve the problem. You can find more details here: actions/runner-images#9591.
There was a problem hiding this comment.
Ed's comment seems fine to me, might help with clarity.
Will we run into any issues in the future with this macOS "downgrade"?
There was a problem hiding this comment.
Sure, I'll optimize it. The downgrade does not impact the SDK, it simply enables tests to run normally.
There was a problem hiding this comment.
@eb-smith-affirm @bf-affirm It has been optimized, thanks for your response.
|
Also the tests fail. What do you use as the CI/CD? |
No description provided.