fix: Update sql.py (feast-dev#3096)

* Update sql.py Fix a bug that `name = name or obj.name if hasattr(obj, "name") else None` has wrong order sequence. Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * add test Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * add test Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> * fix lint Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com> Signed-off-by: hao-affirm <104030690+hao-affirm@users.noreply.github.com>
Affirm · Aug 17, 2022 · 35d8c48 · 35d8c48
1 parent dc85d5a
commit 35d8c48
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/sdk/python/feast/infra/registry/sql.py b/sdk/python/feast/infra/registry/sql.py
@@ -695,7 +695,7 @@ def _apply_object(
     ):
         self._maybe_init_project_metadata(project)
 
-        name = name or obj.name if hasattr(obj, "name") else None
+        name = name or (obj.name if hasattr(obj, "name") else None)
         assert name, f"name needs to be provided for {obj}"
 
         with self.engine.connect() as conn:

diff --git a/sdk/python/tests/unit/test_sql_registry.py b/sdk/python/tests/unit/test_sql_registry.py
@@ -551,3 +551,25 @@ def test_apply_data_source(sql_registry):
     assert registry_batch_source == batch_source
 
     sql_registry.teardown()
+
+
+@pytest.mark.skipif(
+    sys.platform == "darwin" and "GITHUB_REF" in os.environ,
+    reason="does not run on mac github actions",
+)
+@pytest.mark.parametrize(
+    "sql_registry",
+    [
+        lazy_fixture("mysql_registry"),
+        lazy_fixture("pg_registry"),
+        lazy_fixture("sqlite_registry"),
+    ],
+)
+def test_update_infra(sql_registry):
+    # Create infra object
+    project = "project"
+    infra = sql_registry.get_infra(project=project)
+
+    # Should run update infra successfully
+    sql_registry.update_infra(infra, project)
+    sql_registry.teardown()