-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification: In-Memory Registry #96
base: 0.28-affirm
Are you sure you want to change the base?
Conversation
implementation ckpt 1 better type checking plus some bug fixes more impl
3f8ecd5
to
2949d59
Compare
@@ -304,9 +303,10 @@ def __copy__(self): | |||
aggregations=self.aggregations, | |||
mode=self.mode, | |||
timestamp_field=self.timestamp_field, | |||
source=self.source, | |||
source=self.stream_source, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bug in __copy__
. self.source
isn't defined for SFV objects; instead, stream_source
serves the same role as source
.
udf=self.udf, | ||
) | ||
fv.entities = self.entities |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typing bug: type(self.entities) == List[str]
while FeatureView
's constructor requires Union[List[Entity], None]
.
Specification: In-Memory Registry
Design
A
MemoryRegistry
is a Docker image derived mapping fromFeastResource
identifiers to in-memory Python objects, making it stateless between pods and deploys. AFeastResource
is a union of resource types:Some general constraints:
MemoryRegistry
should subclassBaseRegistry
and behave like any other Feast registry duringapply
calls,FeatureStore
instance is constructed,MemoryRegistry
should be populated by a thread-localfeast apply
call,apply_*
andget_*
calls toMemoryRegistry
should use / return shallow-copied objects to reduce the risk of side effects,MemoryRegistry
instances should be immutable once theis_built
flag is set,proto
calls toMemoryRegistry
should be evaluated on-demand to prevent space overhead,MemoryRegistry
instance should not exceed10MB
of space usage (as determined bylen(dill.dumps(registry_instance))
. At the moment (2023/10/10), the registry requires 0.3MB of RAM. MMAPing portions of the registry may be needed as things scale.