Ashwin/patch spark3 jars #17
Open
+132
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metra
approved these changes
Oct 13, 2021
| // We need this in K8s cluster mode so that we can upload local deps | ||
| // via the k8s application, like in cluster mode driver | ||
| childClasspath ++= resolvedMavenCoordinates.split(",") | ||
| } else { | ||
| // In K8s client mode, when in the driver, add resolved jars early as we might need |
| for (jar <- resolvedMavenCoordinates.split(",")) { | ||
| addJarToClasspath(jar, loader) | ||
| } | ||
| } |
There was a problem hiding this comment.
I'm not sure why you added if (isKubernetesClusterModeDriver) to the else branch but I presume it's for a good reason.
There was a problem hiding this comment.
It's because when spark-submit is in the k8s driver - deployMode == client
val isKubernetesCluster = clusterManager == KUBERNETES && deployMode == CLUSTER
val isKubernetesClient = clusterManager == KUBERNETES && deployMode == CLIENT
val isKubernetesClusterModeDriver = isKubernetesClient &&
sparkConf.getBoolean("spark.kubernetes.submitInDriver", false)
python/pyspark3/version.py
Outdated
| @@ -16,4 +16,4 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
|
|
|||
| __version__ = "3.1.2+affirm4" | |||
| __version__ = "3.1.2+affirm8" | |||
| <artifactId>jackson-dataformat-yaml</artifactId> | ||
| </exclusion> | ||
| </exclusions> | ||
| </dependency> |
| return serviceHost != null && serviceHost.length > 0 | ||
| } | ||
|
|
||
| def getHomeDir(): String = { |
There was a problem hiding this comment.
Not sure what sets it, but it's always present on k8s containers. We have something similar in ml_pipelines
There was a problem hiding this comment.
I meant more are you writing this code from scratch or are you porting it from somewhere?
There was a problem hiding this comment.
Oh it's coming from @daggertheog's diff for the spark 2 k8s auth issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?