Improve Home Assistant Support for Notification Listener #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+180
to
+181
| # TODO I commented this because it fails for me in Home Assistant | ||
| #run_in_event_loop(blueConAPIClient.__notificationInfoStorage.storePersistentId(idstr)) |
There was a problem hiding this comment.
This needs to be fixed before merging to main, as without persisting the IDs that were received, they will not be sent with the login request and FCM will send them again to be processed.
There was a problem hiding this comment.
Yep, I agree. At least we have a good entry point to be testing where we receive notifications to Home Assistant
|
Merged to event-loop-main. You have pre-releases of both the library (0.5.0a1 on pypy) and the integration (0.7.0-alpha.1) to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the startNotificationListener function by adding support for Home Assistant. Key changes include:
These changes improve the flexibility and stability of the notification listener across different environments.
Can you merge it to a new branch? So we can test it better. I don't have permission for that.
@AfonsoFGarcia