Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fix from https://github.com/MystenLabs/sui/pull/17934 #1

Conversation

wlmyng
Copy link

@wlmyng wlmyng commented Jun 18, 2024

Description

Adds e2e tests to the sui-graphql-e2e-tests suite to test new behavior from MystenLabs#17934

The nested_dof.move tests behavior of a Parent -> Child1 -> Child2 setup, while the immutable_dof.move tests state when we make Child1 of the same setup immutable.

Btw, I'm not that good with github foo, so this is what I came up with. Lmk if there's an easier way to land these commits!

Test plan

New tests


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:

Copy link

@unmaykr-aftermath unmaykr-aftermath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, this is also the first time I'm in a situation where someone wants to add commits to my PR's fork 😅

@unmaykr-aftermath unmaykr-aftermath merged commit f6fe4a7 into AftermathFinance:unmaykr/fix-graphql-nested-dof-queries Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants