Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified default end_state_reason #353

Merged

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Aug 13, 2024

📥 Pull Request

📘 Description
Seeing this message in the dashboard it wasn't immediately clear that this was AgentOps telling the user they didn't call end_session(). It read as if there was a function in their code called end_session()

Thank you for your contribution to Agentops!

@HowieG HowieG requested a review from siyangqiu August 13, 2024 23:53
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 44.94% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
agentops/client.py 68.55% <ø> (ø)

... and 16 files with indirect coverage changes

@HowieG HowieG enabled auto-merge (squash) August 14, 2024 20:28
@HowieG HowieG merged commit 58d9a47 into main Aug 14, 2024
12 of 13 checks passed
@HowieG HowieG deleted the eng-402-add-a-tooltip-reminder-did-you-forget-to-run-end_session branch August 14, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants