Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Travel Fixes #364

Merged
merged 11 commits into from
Aug 16, 2024
Merged

Time Travel Fixes #364

merged 11 commits into from
Aug 16, 2024

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Aug 16, 2024

📥 Pull Request

📘 Description
yaml dependency was missing due to pyproject.toml not being merged correctly
switching from string matching the entire messages object to just matching the content of each message object in messages. fixes bug where order of role/content resulted in cache miss

@HowieG HowieG requested a review from siyangqiu August 16, 2024 00:18
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 30 lines in your changes missing coverage. Please review.

Files Patch % Lines
agentops/time_travel.py 9.09% 30 Missing ⚠️
Flag Coverage Δ
unittests 44.51% <9.09%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
agentops/time_travel.py 32.07% <9.09%> (-7.49%) ⬇️

... and 1 file with indirect coverage changes

@HowieG HowieG merged commit d4d7be8 into main Aug 16, 2024
11 of 12 checks passed
@HowieG HowieG deleted the timetravel-fixes branch August 16, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants