Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event decorators have default names #367

Merged
merged 3 commits into from
Aug 21, 2024
Merged

event decorators have default names #367

merged 3 commits into from
Aug 21, 2024

Conversation

bboynton97
Copy link
Contributor

@record_action and @record_tool both will use the function's name as the default event name if none is supplied.

Tests

@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Files Patch % Lines
agentops/decorators.py 71.42% 2 Missing and 2 partials ⚠️
Flag Coverage Δ
unittests 43.66% <71.42%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
agentops/decorators.py 67.75% <71.42%> (-0.08%) ⬇️

@bboynton97 bboynton97 enabled auto-merge (squash) August 20, 2024 23:33
@bboynton97
Copy link
Contributor Author

Closes ENG-584

@bboynton97 bboynton97 merged commit b9f9547 into main Aug 21, 2024
12 of 13 checks passed
@bboynton97 bboynton97 deleted the record-action-name branch August 21, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HowieG HowieG HowieG approved these changes

@siyangqiu siyangqiu Awaiting requested review from siyangqiu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboynton97 @HowieG