Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing duplicate llm_pkey errors #389

Merged
merged 10 commits into from
Sep 17, 2024
Merged

Fixing duplicate llm_pkey errors #389

merged 10 commits into from
Sep 17, 2024

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Sep 14, 2024

📥 Pull Request

📘 Description
Users and notebook automation reported duplicate llm_pkey errors which resulted from our refactor of llmprovider. Now that they are singletons there was a shared resource issue

🔄 Related Issue (if applicable)
Users reported duplicate llm_pkey errors

🎯 Goal
Make llm tracker logic thread-safe

🧪 Testing
Spellcaster and notebook automation

Thank you for your contribution to Agentops!

@HowieG HowieG changed the title Fixed for multithreading and clarity Fixing duplicate llm_pkey errors Sep 14, 2024
Copy link

codecov bot commented Sep 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 126 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/llms/anthropic.py 0.00% 23 Missing ⚠️
agentops/llms/cohere.py 0.00% 21 Missing ⚠️
agentops/llms/groq.py 0.00% 21 Missing ⚠️
agentops/llms/litellm.py 0.00% 21 Missing ⚠️
agentops/llms/openai.py 0.00% 21 Missing ⚠️
agentops/llms/ollama.py 0.00% 19 Missing ⚠️
Flag Coverage Δ
unittests 44.39% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/llms/__init__.py 29.72% <ø> (-0.94%) ⬇️
agentops/llms/ollama.py 25.31% <0.00%> (ø)
agentops/llms/cohere.py 14.00% <0.00%> (ø)
agentops/llms/groq.py 16.51% <0.00%> (ø)
agentops/llms/litellm.py 15.21% <0.00%> (ø)
agentops/llms/openai.py 13.88% <0.00%> (ø)
agentops/llms/anthropic.py 12.58% <0.00%> (ø)

agentops/time_travel.py Outdated Show resolved Hide resolved
agentops/llms/anthropic.py Show resolved Hide resolved
Copy link
Contributor

@bboynton97 bboynton97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siyangqiu siyangqiu merged commit fecf20c into main Sep 17, 2024
11 of 12 checks passed
@siyangqiu siyangqiu deleted the concurrency-fixes branch September 17, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants