Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added try catch and extra cases to safe_serialize #421

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Added try catch and extra cases to safe_serialize #421

merged 1 commit into from
Sep 21, 2024

Conversation

areibman
Copy link
Contributor

📥 Pull Request

📘 Description
Safe serialize really wasn't that safe. Added a try catch and a few more cases

@areibman areibman merged commit 122ad1d into main Sep 21, 2024
10 checks passed
@areibman areibman deleted the eng-634-autogen-safe_serialize-failing branch September 21, 2024 00:39
@codecov Codecov
Copy link

codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentops/helpers.py 10.00% 17 Missing and 1 partial ⚠️
Flag Coverage Δ
unittests 44.34% <10.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/helpers.py 62.24% <10.00%> (-3.69%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboynton97 bboynton97 bboynton97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@areibman @bboynton97