Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make end_state default to "Indeterminate" when creating session #472

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

HowieG
Copy link
Contributor

@HowieG HowieG commented Oct 30, 2024

We had many sessions with null end_states which was causing our pie chart to seem to be "missing" sessions

@HowieG HowieG requested review from areibman and siyangqiu October 30, 2024 00:24
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 44.55% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
agentops/session.py 61.81% <100.00%> (ø)

... and 1 file with indirect coverage changes

@HowieG HowieG changed the title end_state defaults to "Indeterminate" when creating session Make end_state default to "Indeterminate" when creating session Oct 30, 2024
Copy link
Contributor

@areibman areibman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this. We made an early on decision to have it be none but TBH makes sense to have it default

@HowieG HowieG merged commit 4ce6f80 into main Oct 30, 2024
11 checks passed
@HowieG HowieG deleted the null-end-states branch October 30, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants