-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Updated notebooks that publish to examples docs pages #585
base: main
Are you sure you want to change the base?
Conversation
@TKTSWalker have a look here as I said before. |
Hey, just giving things a look right now! There seems to be be 2 blocks for CamelAI on the intiial readme to begin Mine's is the second one although with a broken link (from the links being set to the wrong place, examples/camel is now examples/camel_examples)! I mainly formatted it that way to match the formatting of the rest for readability (well with the lower agents anyways), the Installation part is definitely better than what I placed for sure though! I'm also surprised there isn't some sort of general glossary for example files if you guys would rather not have a reference to the github side journals! Adding an area to the bottom can help greatly with this, having names for each integration and a quickview of what's within! Then on the journal end things look mostly fine (although I have been awake for the last 48h working on a few projects so I might be missing details here)! One thing I always like to do when making journals though is simplify terms and logic to best fit the example (although I should use the technical terms a little more)! So I was thinking maybe I could spin my hand and make examples with the simple terms for newcomers and once again for pros! As an example, one snippet you put was; "first we'll create an instance of the AO LangchainCallbackHandler. After the handler is initialized, a session will be recorded automatically." This could be mirrored with something like "We will create an object for holding data called "Variable Name". When we call it, AgentOps will automatically record for us!" Or something like that, just throwing ideas around there more than anything else though! The CamelAI page has more broken references in general relating to files, although I like how you implemented the training data link way more! I'll be a little busy today as i've gotta work on something for a little project of mines and handle a few other things, but if you want me to hop on fixing these through a push request to your repo it's something I can do! |
Updated notebooks that publish to examples docs pages
Purpose
Changes
v1/examples/langchain
v1/examples/multion
v1/examples/simple_agent
v1/examples/camel
Miscellaneous
camel-simple-examples.ipynb
langchain_v0_example.ipynb