Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add traceback for error handling in LLM Apps service #1614

Merged
merged 7 commits into from
May 6, 2024
Merged

Add traceback for error handling in LLM Apps service #1614

merged 7 commits into from
May 6, 2024

Conversation

mmabrouk
Copy link
Member

@mmabrouk mmabrouk commented May 5, 2024 •
edited
Loading

This pull request adds a traceback for error handling in the LLM Apps service. The traceback is generated using the traceback module and provides more detailed information about the error that occurred during app invocation.

It also instruments evaluation exceptions in sentry

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 5, 2024
@vercel Vercel
Copy link

vercel bot commented May 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 7:51pm

@dosubot dosubot bot added Backend enhancement New feature or request python Pull requests that update Python code labels May 5, 2024
@mmabrouk mmabrouk requested review from aybruhm and aakrem May 5, 2024 18:14
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 5, 2024
@mmabrouk
Copy link
Member Author

mmabrouk commented May 5, 2024

CleanShot 2024-05-05 at 21 44 07@2x

@mmabrouk
Copy link
Member Author

mmabrouk commented May 5, 2024

@aakrem @aybruhm this was tested in cloud in cases of errors and without. Please test in oss (specifically for the sentry case)

@mmabrouk mmabrouk self-assigned this May 6, 2024
aybruhm
aybruhm approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @mmabrouk.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 6, 2024
@aybruhm
Copy link
Member

aybruhm commented May 6, 2024

@aakrem @aybruhm this was tested in cloud in cases of errors and without. Please test in oss (specifically for the sentry case)

OSS works. Sentry didn't log any exception.

@mmabrouk mmabrouk merged commit b696d97 into main May 6, 2024
7 checks passed
@mmabrouk mmabrouk deleted the impr/improve-stacktrace-in-case-of-error-in-eval branch May 6, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybruhm aybruhm aybruhm approved these changes

@aakrem aakrem Awaiting requested review from aakrem

Assignees

@mmabrouk mmabrouk

Labels
Backend enhancement New feature or request lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmabrouk @aybruhm