Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: speed up the endpoint get config #1639

Merged
merged 5 commits into from
May 30, 2024
Merged

[Improvement]: speed up the endpoint get config #1639

merged 5 commits into from
May 30, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented May 12, 2024 •
edited
Loading

Description

This PR improves the get_config endpoint latency by 86.7%

Related Issue

Closes #1599

Dependency

commons_#53

Preview

fconfig-latency-improved.webm

@vercel Vercel
Copy link

vercel bot commented May 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 7:46am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Backend improvement labels May 12, 2024
@aybruhm aybruhm requested a review from mmabrouk May 12, 2024 11:35
mmabrouk
mmabrouk requested changes May 12, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @aybruhm

I think this hints that the fetch links behavior in beannie is culprite in a large part.

Can you please benchmark this in cloud with the current version so that we can later assess the improvement in cloud.

I will create an issue to deal with this also in all bottleneck places

agenta-backend/agenta_backend/services/db_manager.py Show resolved Hide resolved
agenta-backend/agenta_backend/services/db_manager.py Show resolved Hide resolved
mmabrouk
mmabrouk requested changes May 15, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some parts of the code that might be broken with this. Can you please take a look at these. Not sure about all of them though

agenta-backend/agenta_backend/services/db_manager.py Show resolved Hide resolved
agenta-backend/agenta_backend/services/db_manager.py Show resolved Hide resolved
agenta-backend/agenta_backend/services/db_manager.py Show resolved Hide resolved
@aybruhm aybruhm requested a review from mmabrouk May 15, 2024 19:11
@aybruhm aybruhm requested a review from mmabrouk May 16, 2024 07:49
mmabrouk
mmabrouk approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aybruhm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 30, 2024
@mmabrouk mmabrouk merged commit ddab8d8 into main May 30, 2024
7 checks passed
@mmabrouk mmabrouk deleted the 1599-age-164-improvement-speed-up-the-endpoint-get_config branch May 30, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
Backend improvement lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[AGE-164] [Improvement] Speed up the endpoint /get_config
2 participants
@aybruhm @mmabrouk