Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sub issue]: Improve Evaluation comparison view to show all ground truth columns #1645

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented May 13, 2024

Issue #1395

Depends on #1606

@bekossy bekossy requested a review from aakrem May 13, 2024 09:00
Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 5:52pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. evaluation typescript labels May 13, 2024
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code is indeed implementing the feature but it feels a bit complicated.
can you please answer the questions below so I can better understand the implementatoin

agenta-web/src/services/evaluations/index.ts Show resolved Hide resolved
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @bekossy you rock!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 14, 2024
@aakrem aakrem merged commit 975b01f into access-to-all-columns May 14, 2024
3 of 5 checks passed
@aakrem aakrem deleted the sub-issue/-improve-eval-comparison-view-to-show-all-ground-truth-columns branch May 14, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants