Move copy message button in the playground to the text input #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…yground-to-the-text-input
dosubot
bot
added
the
size:M
aakrem
requested changes
May 22, 2024
mmabrouk
requested changes
May 22, 2024
There was a problem hiding this comment.
Thanks for the PR @bekossy
I think the current solution does not look good. The copy button hides the text generated. Can you please try the following:
- Move the copy button to the lower right side (instead of the upper side)
- Make the icon transparent and change the color to green
The goal is to make the button not obfuscate the text, yet visible.
Of course, if there is a way to make the text not overflow over the button, that would be great. Not sure if that is feasible however.
dosubot
bot
added
size:L
aakrem
approved these changes
May 24, 2024
|
thanks @bekossy |
aakrem
deleted the
AGE-207/-Move-copy-message-button-in-the-playground-to-the-text-input
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1644