Fix: select model component search bar #1721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced getTextContent function with the option.vlaue
…fix/1717-select-model-component-searchbar
|
@ashrafchowdury is attempting to deploy a commit to the mmabrouk's projects Team on Vercel. A member of the Team first needs to authorize it. |
dosubot
bot
added
size:S
mmabrouk
reviewed
May 30, 2024
agenta-web/src/pages/apps/[app_id]/annotations/human_a_b_testing/[evaluation_id]/index.tsx
Show resolved
Hide resolved
aakrem
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the select model componnet search bar by replacing
getTextContentfunction with theoptions.valueas search query.Majority of the times the
getTextContentfunction return empty string that's why the result was showing empty by replacing it withoptions.valuethe search bar is functioning now.Screenshot
Issue
Closes #1717