Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate fix to #1705 (pydantic v2) #1736

Conversation

mmabrouk
Copy link
Member

@mmabrouk mmabrouk commented Jun 2, 2024

No description provided.

Copy link

vercel bot commented Jun 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2024 4:36pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working typescript labels Jun 2, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jun 2, 2024
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, @mmabrouk.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 3, 2024
@aybruhm aybruhm merged commit 62dcc4a into feature/age-234-migration-upgrade-pydantic-to-v2-with-sdk-backward Jun 3, 2024
4 of 5 checks passed
@aybruhm aybruhm deleted the prfix/pydanticv2 branch June 3, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants