Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Export results in the Evaluation Scenarios view #1763

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Jun 5, 2024

Description

  • Added export button for CSV export
  • Implemented row selection for customized exports

Related Issue

Closes #1696

Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 1:01am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feature Frontend typescript labels Jun 5, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @bekossy

The format of the CSV is not informative / correct. For the main view:


"Variant","Testset","Exact Match","simy","Avg. Latency","Total Cost","Created","Status"
"app.default v2","boo_testset","-","unsupported operand type(s) for +: 'int' and 'NoneType'","1424ms","$0.000589","Invalid Date","[object Object]"
"app.sdf v1","boo_testset","0.71","-","585ms","-","Invalid Date","[object Object]"
"app.default v2","boo_testset","0.57","-","570ms","-","Invalid Date","[object Object]"
"app.default v1","boo_testset","0.57","-","615ms","-","Invalid Date","[object Object]"
"app.default v1","boo_testset","0.71","-","609ms","-","Invalid Date","[object Object]"

CleanShot 2024-06-05 at 16 13 52@2x

--

For the comparison and the evaluation result view, the variants are not saved in the headers, there is therefore no way to know which variant is which:

"Input: country","","Output","Output","Exact Match","Exact Match","Contains Json","Contains Json","Latency","Latency","Cost","Cost"
"Nauru","","The capital of Nauru is Yaren.","The capital of Nauru is Yaren.","No correct answer keys provided.","No correct answer keys provided.","False","False","1544ms","1276ms","$0.000067","$0.000067"
"Tuvalu","","The capital of Tuvalu is Funafuti. It is also the largest city in the country.","The capital of Tuvalu is Funafuti.","No correct answer keys provided.","No correct answer keys provided.","False","False","1775ms","1322ms","$0.000085","$0.000065"
"Brunei","","The capital of Brunei is Bandar Seri Begawan.","The capital of Brunei is Bandar Seri Begawan.","No correct answer keys provided.","No correct answer keys provided.","False","False","2038ms","1450ms","$0.000071","$0.000071"
"Kiribati","","The capital of Kiribati is Tarawa.","The capital of Kiribati is South Tarawa.","No correct answer keys provided.","No correct answer keys provided.","False","False","1567ms","1419ms","$0.000067","$0.000069"
"Comoros","","The capital of Comoros is Moroni.","The capital of Comoros is Moroni.","No correct answer keys provided.","No correct answer keys provided.","False","False","1595ms","1248ms","$0.000067","$0.000067"
"Kyrgyzstan","","The capital of Kyrgyzstan is Bishkek.","The capital of Kyrgyzstan is Bishkek.","No correct answer keys provided.","No correct answer keys provided.","False","False","1606ms","1332ms","$0.000069","$0.000069"
"Azerbaijan","","The capital of Azerbaijan is Baku. It is the largest city in Azerbaijan and serves as the country's political, cultural, and economic center.","The capital of Azerbaijan is Baku.","No correct answer keys provided.","No correct answer keys provided.","False","False","1919ms","1151ms","$0.000102","$0.000059"
"Nigeria","","The capital of Nigeria is Abuja. It became the capital in 1991, replacing Lagos.","The capital of Nigeria is Abuja.","No correct answer keys provided.","No correct answer keys provided.","False","False","1713ms","1290ms","$0.000084","$0.000059"
"afsd","","There is no country or territory with the name ""afsd."" If you provide me with the correct name of the country or territory you are inquiring about, I will be happy to provide you with information about its capital city.","There is no country or region named ""afsd."" Could you provide more context or clarify your question?","No correct answer keys provided.","No correct answer keys provided.","False","False","2172ms","1423ms","$0.000137","$0.000087"

Can you please test (or make sure) that new lines are saved correctly in the CSV. We had this issue for some time.

@bekossy bekossy requested a review from mmabrouk June 6, 2024 00:40
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 6, 2024
@bekossy
Copy link
Member Author

bekossy commented Jun 6, 2024

Thank you for the review @mmabrouk, I have made the requested changes and also prevented new lines break in the CSV file

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @bekossy !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 6, 2024
@mmabrouk mmabrouk merged commit c6ab18c into main Jun 6, 2024
8 checks passed
@mmabrouk mmabrouk deleted the AGE-262/-export-evaluation-results-from-the-UI branch June 6, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AGE-262] Exporting evaluations results from the UI
2 participants