Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: UI Creates Duplicate Entries When Saving New Test Set Multiple Times #1813

Merged
merged 3 commits into from
Jun 26, 2024
Merged

[Bug]: UI Creates Duplicate Entries When Saving New Test Set Multiple Times #1813

merged 3 commits into from
Jun 26, 2024

Conversation

bekossy
Copy link
Member

@bekossy bekossy commented Jun 25, 2024

No description provided.

@vercel Vercel
Copy link

vercel bot commented Jun 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 2:55pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working UI labels Jun 25, 2024
mmabrouk
mmabrouk requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment in Slack. I feel this overcomplicates the solution. Unless I made a mistake in my logic

mmabrouk
mmabrouk requested changes Jun 25, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bekossy see the comment

agenta-web/src/components/TestSetTable/TestsetTable.tsx Outdated Show resolved Hide resolved
@bekossy bekossy requested a review from mmabrouk June 25, 2024 14:54
mmabrouk
mmabrouk approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @bekossy !

QA'd create of new test set and editing test sets and it worked without issue

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 26, 2024
@mmabrouk mmabrouk merged commit fe30c46 into main Jun 26, 2024
8 checks passed
@mmabrouk mmabrouk deleted the AGE-356/-Testset-UI-creates-duplicate-entries-when-saving-new-testset-multiple-times branch June 26, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekossy @mmabrouk