Fix two likely causes of infinitely running evaluations #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle uncaught exceptions in aggregate_ai_critique() and in evaluate()
…handle unknown values_
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mmabrouk
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Thanks @jp-agenta ! Great work.
I've added a couple of minor comments here and there.
agenta-web/src/components/pages/evaluations/cellRenderers/cellRenderers.tsx
Show resolved
Hide resolved
agenta-web/src/components/pages/evaluations/cellRenderers/cellRenderers.tsx
Outdated
Show resolved
Hide resolved
Standardizes stacktrace to traceback.format_exc() (in all three files) and message to str(exc) (in aggregation_service.py)
|
QA tests
|
mmabrouk
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
Thanks @jp-agenta and @bekossy
From my side, lgtm, there are the minor comments from @jp-agenta that I agree with (added a comment there). As soon as we have this you go ahead and merge @jp-agenta
agenta-web/src/components/pages/evaluations/cellRenderers/cellRenderers.tsx
Show resolved
Hide resolved
|
@all-contributors please add @jp-agenta for code and bugs |
|
I've put up a pull request to add @jp-agenta! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handles uncaught exceptions with
try-exceptindef aggregate_ai_critique()and inevaluate().Related Issues
Not linked yet.