Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluation status which never was set to Queued. #1841

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Fix evaluation status which never was set to Queued. #1841

merged 4 commits into from
Jul 5, 2024

Conversation

jp-agenta
Copy link
Contributor

Description
Evaluations are initially Queued and only move to Started when the worker actually starts on the task.

Related Issues
Not linked yet.

Fix (AGE-381)
337ba11 
Evaluations are initially Queued and only move to Started when the worker actually starts on the task.
@vercel Vercel
Copy link

vercel bot commented Jul 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 0:05am

mmabrouk
mmabrouk reviewed Jul 4, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the solution. Simple and effective. lgtm

@jp-agenta jp-agenta marked this pull request as ready for review July 5, 2024 08:20
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Backend bug Something isn't working labels Jul 5, 2024
mmabrouk
mmabrouk requested changes Jul 5, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jp-agenta please see the comments

agenta-backend/agenta_backend/tasks/evaluations.py Outdated Show resolved Hide resolved
agenta-backend/agenta_backend/tasks/evaluations.py Outdated Show resolved Hide resolved
agenta-backend/agenta_backend/tasks/evaluations.py Outdated Show resolved Hide resolved
@jp-agenta
refactor(backend): Review PR comments
be92ce3 
Remove redundant celery state updates, update celery configuration, use enum properly.
@jp-agenta
Copy link
Contributor Author

@mmabrouk -- added refactoring based on comments.

@jp-agenta
Copy link
Contributor Author

QA tests

  • Adding a delay at the beginning of the evaluation.py and checking that the frontend shows Queued.
  • This could be automated in test_variant_evaluators_router.py with a lenghty evaluation and some polling with delays to fetch the evaluation status.

mmabrouk
mmabrouk approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jp-agenta
lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 5, 2024
@mmabrouk mmabrouk merged commit f53f9c1 into main Jul 5, 2024
9 checks passed
@mmabrouk mmabrouk deleted the fix/missing-queued-evaluation-status branch July 5, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
Backend bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jp-agenta @mmabrouk @bekossy