Fix incomplete stacktraces in evaluations #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve stacktrace quality in evaluations. Still not shown in UI.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mmabrouk
reviewed
Jul 4, 2024
There was a problem hiding this comment.
Thank @jp-agenta for the PR!
Is this compatible with #1708 I see both changing the cellRenderers (we use a modal there). I have set you as a reviewer there. Maybe it makes sense to review and merge that one first, then update this one (also it would allow us to see how all these error messages show from a user perspective).
|
It is compatible, yes. |
dosubot
bot
added
size:M
|
QA tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses
tracebackto better handle stacktraces and then shows the stacktrace in a tooltip in the web UI.Related Issues
Not linked yet.