Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix]: CLI config (app_id) mismatch with backend UUID handling #1858

Merged

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Jul 8, 2024

Description

This PR addresses the issue by implementing a new function, get_object_uuid, in the db_manager. The function ensures that the app_id is correctly interpreted as a UUID. The list_variants and build_image endpoints have been updated to use this function, ensuring compatibility between the CLI and backend.

Changes

  • Added get_object_uuid function to db_manager.
  • Updated list_variants and build_image endpoints to use the new function.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 1:56pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 8, 2024
@dosubot dosubot bot added Backend bug Something isn't working CLI labels Jul 8, 2024
@aybruhm aybruhm changed the title [Bug Fix]: CLI Config Mismatch with Backend UUID Handling [Bug Fix]: CLI config (app_id) mismatch with backend UUID handling Jul 8, 2024
@aybruhm aybruhm requested a review from aakrem July 8, 2024 13:57
Copy link
Collaborator

@aakrem aakrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 8, 2024
@aakrem aakrem merged commit ffd9278 into postgres Jul 8, 2024
6 checks passed
@aakrem aakrem deleted the bugfix/backward-compatibility-when-redeploying-apps branch July 8, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working CLI lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants