Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Added postgres to gh compose for production use #1860

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Jul 9, 2024

Description

This PR enhances the gh compose configuration for production use by introducing PostgreSQL and PgAdmin services. Additionally, it adds the necessary database source configuration to make possible for data migration from MongoDB to PostgreSQL.

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 8:56am

@aybruhm aybruhm marked this pull request as ready for review July 9, 2024 09:11
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jul 9, 2024
@aybruhm aybruhm requested a review from mmabrouk July 9, 2024 09:14
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the docker compose now includes both postgres and mongodb. I think this is not a sustainable solution since at some point we would want to remove mongodb. Instead what I would suggest is having too docker-composes the normal one, and one special for the migration. I would also think we should have a note in the documentation on how to do in the case of using gh

@aybruhm
Copy link
Member Author

aybruhm commented Jul 9, 2024

I see that the docker compose now includes both postgres and mongodb. I think this is not a sustainable solution since at some point we would want to remove mongodb. Instead what I would suggest is having too docker-composes the normal one, and one special for the migration. I would also think we should have a note in the documentation on how to do in the case of using gh

I'm not sure if I understand you completely. From what I gather, we plan to phase out MongoDB at some point. This would require us to notify our users through all available channels (newsletter, documentation, Slack) that we'll be removing MongoDB from our current compose files.

Why do we need a separate compose file for the migration? Won't we essentially have the same services as in the default OSS compose?

@aybruhm aybruhm requested a review from mmabrouk July 9, 2024 09:42
@mmabrouk
Copy link
Member

mmabrouk commented Jul 9, 2024

I see that the docker compose now includes both postgres and mongodb. I think this is not a sustainable solution since at some point we would want to remove mongodb. Instead what I would suggest is having too docker-composes the normal one, and one special for the migration. I would also think we should have a note in the documentation on how to do in the case of using gh

I'm not sure if I understand you completely. From what I gather, we plan to phase out MongoDB at some point. This would require us to notify our users through all available channels (newsletter, documentation, Slack) that we'll be removing MongoDB from our current compose files.

Why do we need a separate compose file for the migration? Won't we essentially have the same services as in the default OSS compose?

Because the current docker-compose.gh contains both postgres and mongodb. However we are not using mongodb at all in OSS. So, the only reason we have this is to allow the migration.

So, basically you are saying we keep the docker composes as is right now (with the two services running in parallel), and then in v0.20, we remove mongodb, and then if someone wants to migrate, they need to go back to the release v0.19, and use that docker compose to migrate. Right?

@aybruhm
Copy link
Member Author

aybruhm commented Jul 9, 2024

So, basically you are saying we keep the docker composes as is right now (with the two services running in parallel), and then in v0.20, we remove mongodb, and then if someone wants to migrate, they need to go back to the release v0.19, and use that docker compose to migrate. Right?

Yes. In addition to that, we could also update the Postgres migration documentation to have users stop (and remove) the MongoDB container once they confirm that the migration was successful and their data is intact.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 9, 2024
@mmabrouk mmabrouk merged commit 804895e into main Jul 9, 2024
7 checks passed
@mmabrouk mmabrouk deleted the feature/update-oss-production-image-pipeline branch July 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants