-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug fix]: CLI overwriting an app does not update configuration #1863
[Bug fix]: CLI overwriting an app does not update configuration #1863
Conversation
…nd replace print for logger.info
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't the right fix just modify line 43 in agenta_init.py
to be
api_key: Optional[str] = ""
?
I don't understand the reason for all the other changes (except 480 in variant_commands
which looks like dead code, and 1784 in db_manager
which fixed an edge case and the use of logger instead of print)
Noted. I'll create a new PR with the right changes. |
…ng-an-app-from-cli [Bug fix]: CLI overwriting an app does not update configuration #1863
Description
This PR resolves the bug that overwrites an app from the CLI, which leads to the configuration not been updated.
Related Issue
Closes AGE-396
Changes
api_key
to an empty string (in OSS) when it is None to avoid fern raising aNoneType
error during request header serialization.SaveConfigPayload
API model and associated arguments to eliminate redundancy and potential confusion.payload.overwrite
and replaced print statements withlogger.info
for better logging practices insave_config
API router.serve_cli
variant command inagenta-cli
.