Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker compose cleanup from mongo post-migration #1871

Merged
merged 3 commits into from
Jul 11, 2024
Merged

docker compose cleanup from mongo post-migration #1871

merged 3 commits into from
Jul 11, 2024

Conversation

aakrem
Copy link
Collaborator

@aakrem aakrem commented Jul 10, 2024

  • Add dedicated docker compose for migration
  • remove mongo from all docker composes
  • Updating migration docs

@vercel Vercel
Copy link

vercel bot commented Jul 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 1:26pm

@aakrem aakrem marked this pull request as ready for review July 10, 2024 13:26
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 10, 2024
@dosubot dosubot bot added Backend documentation Improvements or additions to documentation labels Jul 10, 2024
@aakrem aakrem changed the title Migration and cleanup docker compose cleanup from mongo post-migration Jul 10, 2024
@aakrem aakrem requested a review from aybruhm July 10, 2024 13:49
aybruhm
aybruhm requested changes Jul 10, 2024
View reviewed changes
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. In the case of users running Agenta using the gh compose, how do they run the migration?

@aakrem
Copy link
Collaborator Author

aakrem commented Jul 11, 2024

they still can do the same 🤔 what's the problem there?

@aakrem aakrem merged commit 143fa1e into main Jul 11, 2024
10 checks passed
@aakrem aakrem deleted the migration-and-cleanup branch July 11, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybruhm aybruhm aybruhm requested changes

Assignees
No one assigned
Labels
Backend documentation Improvements or additions to documentation size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aakrem @aybruhm