[Bug fix]: Human evaluation UI breaks when a variant has been deleted #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… both evaluations and human evaluations for testset resource type
…ants in human evaluations
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aakrem
reviewed
Jul 10, 2024
… both evaluations (human and auto) for variant resource type
…is valid for deletion
dosubot
bot
added
size:L
aakrem
approved these changes
Jul 11, 2024
aakrem
deleted the
feature/age-414-bug-human-evaluation-ui-breaks-when-a-variant-has-been
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
Related Issue
Closes AGE-414
Changes
fetch_evaluations_by_resourcefunction indb_managerto retrieve both human and automatic evaluations for thetestset&variantresource type. This ensures that users are notified of the number of resources using the testset or variant before deletion.construct_app_container_urlrouter to handle backward compatibility when viewing a single human evaluation after a variant is deleted.Additional Information
When a user views a human evaluation, the "Run All" button is still visible. Clicking on it will result in a 500 server error because the constructed app container URL for the variant no longer works.