-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: implemented human evaluations #2047
Feat: implemented human evaluations #2047
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work on this PR. Here are some changes to address:
- Let's make it clear that both the
SingleModelEvaluation
andAbTestingEvaluation
are reusable components and import that where needed. - The "Compare" button in AB Testing should navigate to the evaluation compare view.
- We currently don’t have new changes in the Automatic Evaluation view?
- Please resolve the merge conflicts.
- refactored code
Changes summary:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s also remove the previous Annotation code
http://localhost/apps/APP_ID/annotations/single_model_test
should not be a valid path
And fix the failing cypress tests
Changes summary:
|
3cbc196
to
0a02a48
Compare
…ement-human-evaluations
60d237e
into
AGE-587/-implement-evaluation-main-page
Descriptions
Implemented human evaluations on evaluation page reusing the
SingleModelEvalOverview.tsx
andAbTestingEvalOverview.tsx
component from overview page by conditionally made them adjustable, so that both use in overview and evaluations page.