Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: automatic evaluation functionalities #2058

Conversation

ashrafchowdury
Copy link
Collaborator

Description

Automatic evaluation with new UI and features.

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:46am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:46am

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 5, 2024
@dosubot dosubot bot added CLI enhancement New feature or request evaluation UI labels Sep 5, 2024
Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @ashrafchowdury. Just a couple of changes needed:

  • Display both Evaluator name and type in the column header (similar to the previous implementation)
  • Ensure the Compare button is enabled after selecting 2 or more successful eval results
  • Enable hiding of individual eval result columns
  • Status value should update from 0s when running
  • Improve Filters:
    • Filter Status by its set values (Completed, Completed with Errors, etc.)
    • Allow sorting Latency and Cost in ascending/descending order

@ashrafchowdury
Copy link
Collaborator Author

ashrafchowdury commented Sep 6, 2024

New Changes:

  • Displayed both Evaluator name and type in the column header
  • Ensure the Compare button is enabled after selecting 2
  • Enabled hiding of individual eval result columns
  • Fixed Status value should update from 0s when running
  • Improved filters for status column
  • Added sorting in Latency and Cost column

Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @ashrafchowdury

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 9, 2024
@bekossy bekossy merged commit 62b5745 into AGE-587/-implement-evaluation-main-page Sep 9, 2024
6 checks passed
@bekossy bekossy deleted the enhance/automatic-tab-functionalitis branch September 9, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI enhancement New feature or request evaluation lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants