-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Projects - Checkpoint 2 #2065
Merged
aakrem
merged 62 commits into
refactor/project-structure
from
oss-feature/age-667-project-2-update-scope-in-database_routers
Sep 28, 2024
Merged
[feature] Projects - Checkpoint 2 #2065
aakrem
merged 62 commits into
refactor/project-structure
from
oss-feature/age-667-project-2-update-scope-in-database_routers
Sep 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s and evaluations models to be project-specific
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ng relationship mapper in models
… applications, & evaluators
…n-database_routers
…e down_revision head
…reate Alembic migration for project_id scoping
…exists in a table
… alembic migration
jp-agenta
approved these changes
Sep 26, 2024
Base automatically changed from
feature/age-662-project-1-add-update-tables-columns
to
refactor/project-structure
September 27, 2024 09:41
…oject-2-update-scope-in-database_routers
…pace for testsets has no property app_id in test_create_evaluation_with_no_llm_keys testcase
- fetch evaluators with an app_id - delete evaluators with no app_id
Thank you @aybruhm @jp-agenta @bekossy 👏 👏 |
aakrem
deleted the
oss-feature/age-667-project-2-update-scope-in-database_routers
branch
September 28, 2024 11:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces backward compatibility enhancements to:
Related Issues
Closes:
Sibling PRs
Changes
Project-Specific Scoping
project_id
to database entities including testsets, applications, evaluators, evaluations models and beyond.Database and Migration Adjustments
project_id
in DB entities, add default project to scoped DB entities, update evaluators with app names, etc.Utility Functions and Middleware
project_id
from request ; path parameters, query parameters or request body.project_id
to request state.Other Changes
project_id
fromrequest.state
.AppDB
andEvaluatorConfigDB
to deprecated models file.What to QA
Acceptance Tests
Ensure that the above items work without triggering any 500 errors from the backend.