Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: implemented app management view #2092

Merged
merged 28 commits into from
Oct 21, 2024

Conversation

ashrafchowdury
Copy link
Collaborator

Description

This PR significantly improves the App Management UI, enhancing user experience and workflow efficiency.

Related Issue

Closes AGE-914.

Key Changes

  • Redesigned the app selection interface for a more intuitive user experience.
  • A search bar was added to the app management page for easier apps navigation.

QA Instructions

  • Create App: Ensure the app creation process works smoothly through the UI.
  • Search Apps: Test the search functionality to confirm you can easily find apps by name or other criteria.

Copy link

vercel bot commented Sep 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:17pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:17pm

@mmabrouk
Copy link
Member

mmabrouk commented Oct 1, 2024

@ashrafchowdury I think the auto-resizing feature for the cards has not been implemented correctly. Can you please sync with Ahmed. Thanks!

@mmabrouk
Copy link
Member

mmabrouk commented Oct 6, 2024

@bekossy can you please review

Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ashrafchowdury however there is an issue where, after deleting an app and attempting to rename other apps, the input field displays an incorrect app name that doesn't match the selected app

Here's the jam recording link: https://jam.dev/c/cdabced9-d34e-4b0b-9bd1-9da492b326ee

@ashrafchowdury
Copy link
Collaborator Author

ashrafchowdury commented Oct 15, 2024

@bekossy, I haven't seen the issue anywhere else apart from the Vercel preview. 😕

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When we create an application, we poll the file openapi.json each five seconds while we wait for it to start. Right now each of these polls is returning an internal server error! It looks like something is failing while it is not!
CleanShot 2024-10-21 at 20 25 47@2x

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem was resolved, it had nothing to do with the PR

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 21, 2024
@mmabrouk mmabrouk dismissed bekossy’s stale review October 21, 2024 21:38

Issue happens only in vercel preview

@mmabrouk mmabrouk merged commit b22a883 into main Oct 21, 2024
9 checks passed
@mmabrouk mmabrouk deleted the AGE-914/implement-app-management-view branch October 21, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants