-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI]: implement test sets main view #2102
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashrafchowdury for the PR!
I did not QA'it, just did some smoke testing. I found the following:
- Configuration button does not do anything (check with Ahmed)
- Batch delete functionality does not work
- Rows are sorted from oldest to newest per default. Should be the opposite. If there is a way to add the functionality to change that, that would be nice
- This is an old unrelated issue. But currently if you open a test set then navigate back to the main menu, you always get this modal (even if you did not make any change)
- The modal shown in this case (and any modal here) does not fit the theme / design (please check with Ahmed)
- Can you please remove the option Import from endpoint, from the create new test set modal. It does not make sense imo
- Please ask Ahmed to update the design to have one way to show "Read the docs" (either a button or a text)
- The curl is not correctly highlighted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ashrafchowdury and @jp-agenta
QA'ed and lgtm
Description
This PR improves the Test Sets interface by making it more user-friendly and adding new features to enhance the overall experience and efficiency.
Related Issue
Closes AGE-994
Key Changes
QA Instructions