Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI]: implement test sets main view #2102

Merged
merged 17 commits into from
Oct 9, 2024
Merged

Conversation

ashrafchowdury
Copy link
Collaborator

@ashrafchowdury ashrafchowdury commented Oct 4, 2024

Description

This PR improves the Test Sets interface by making it more user-friendly and adding new features to enhance the overall experience and efficiency.

Related Issue

Closes AGE-994

Key Changes

  • Redesigned the test set creation interface for a more user-friendly experience.
  • Added a search bar to the test set page for easier navigation and filtering.
  • Introduced new features such as cloning and renaming test sets.

QA Instructions

  1. Create a Test Set from scratch: Make sure that creating a test set through the user interface is straightforward and works without problems.
  2. Create a Test Set by Uploading a File: Check that uploading a file creates a test set successfully, with no errors.
  3. Create a Test Set through the API: Ensure that creating a test set using the API works correctly.
  4. Clone a Test Set: Confirm that you can clone an existing test set, and all its data is copied correctly.
  5. Rename a Test Set: After creating a test set, ensure you can rename it using the options in the menu.
  6. Search Test Sets: Test the search bar to ensure it allows you to find test sets easily using names or other details.

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:47am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 6:47am

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury for the PR!

I did not QA'it, just did some smoke testing. I found the following:
CleanShot 2024-10-06 at 17 51 54@2x

  • Configuration button does not do anything (check with Ahmed)
  • Batch delete functionality does not work
  • Rows are sorted from oldest to newest per default. Should be the opposite. If there is a way to add the functionality to change that, that would be nice
CleanShot 2024-10-06 at 17 53 13@2x
  • This is an old unrelated issue. But currently if you open a test set then navigate back to the main menu, you always get this modal (even if you did not make any change)
  • The modal shown in this case (and any modal here) does not fit the theme / design (please check with Ahmed)
  • Can you please remove the option Import from endpoint, from the create new test set modal. It does not make sense imo
CleanShot 2024-10-06 at 17 55 52@2x CleanShot 2024-10-06 at 17 56 04@2x
  • Please ask Ahmed to update the design to have one way to show "Read the docs" (either a button or a text)
  • The curl is not correctly highlighted
CleanShot 2024-10-06 at 17 57 11@2x

Copy link
Contributor

@jp-agenta jp-agenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 9, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury and @jp-agenta
QA'ed and lgtm

@mmabrouk mmabrouk merged commit 727d269 into main Oct 9, 2024
12 of 13 checks passed
@mmabrouk mmabrouk deleted the AGE-994/implement-testset-view branch October 9, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files. UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants