Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): moved testset out of application scope #2111

Merged
merged 6 commits into from
Oct 15, 2024

Conversation

ashrafchowdury
Copy link
Collaborator

@ashrafchowdury ashrafchowdury commented Oct 9, 2024

Description

This PR aims to resolve the UX bug in the testset by moving it from the application scope to the project scope.

Related Issue

Closes AGE-964

QA

  • You should be able to create test sets using all available methods without any issues.
  • All features and functionalities should work as expected.

Copy link

vercel bot commented Oct 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:07pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:07pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
@ashrafchowdury ashrafchowdury changed the title fix(frontend): testset scoping issue fix(frontend): moved testset out of application scope Oct 10, 2024
Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking on "View details" redirects to a 404 Page not found view

Here’s the Jam link: https://jam.dev/c/117b173e-8392-4c1c-b848-0f96d558a949

@bekossy
Copy link
Member

bekossy commented Oct 10, 2024

Screenshot 2024-10-10 at 2 07 44 PM Same here, clicking on View testset in the evaluation view navigates to a 404 page

@bekossy
Copy link
Member

bekossy commented Oct 10, 2024

Screenshot 2024-10-10 at 2 11 51 PM

Same here in the Evaluation Comparison view

@bekossy
Copy link
Member

bekossy commented Oct 10, 2024

Screenshot 2024-10-10 at 2 13 18 PM

Same here in the Evaluation Results view

Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 11, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury !

@mmabrouk mmabrouk merged commit 635eec7 into main Oct 15, 2024
6 checks passed
@mmabrouk mmabrouk deleted the AGE-964/moving-testset-to-project-scrope branch October 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants