Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): added export button on evaluation #2116

Merged
merged 3 commits into from
Oct 15, 2024

Conversation

ashrafchowdury
Copy link
Collaborator

Description

This PR aims to add export data as CSV feature on evaluations.

Related Issue

Closes AGE-1021

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 11:01am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 11:01am

@ashrafchowdury ashrafchowdury marked this pull request as ready for review October 11, 2024 14:15
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 11, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 14, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ashrafchowdury !

I QA'ed the PR. I found this issue:

  • When exporting the A/B test results, the data is not exported in the right format
Variant 1,Variant 2,Test set,Results,Both are good,Flag,Created on
app.default v1,app.fggf v2,country-app_testset,0% | 14.29%,0%,14.29%,"15 Oct 24, 00:00"

Here, we need to export in a parsable format, meaning instead of one Results column which has a string delimited by |.
Instead we want two columns for for Variant A the other Variant B and each having the number.

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Oct 15, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 15, 2024
@mmabrouk mmabrouk merged commit cc62182 into main Oct 15, 2024
9 checks passed
@mmabrouk mmabrouk deleted the enhance/adding-export-feat-on-auto-eval branch October 15, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants