Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix]: agenta CLI does not work anymore post-release (project structure) #2117

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Oct 11, 2024

Description

This PR fixes issues with the Agenta CLI, which stopped working after changes to the project structure were released.

Related Issue

Closes AGE-1057 (Critical)

Sibling PR

Changes

  • Fix AssertionError when creating an app from the CLI due to a missing workspace_id.
  • Resolve TypeError in start_variant function caused by a missing argument after the variant image update.

QA

  • Create an app from the CLI while running in cloud-dev environment.
  • Re-serve a deployed app to verify that updates are applied correctly.

Acceptance Tests

  • Verify that an app can be successfully created from the CLI in the cloud-dev environment without errors.
  • Ensure that the created app can be re-served, confirming the app updates are properly handled.

Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 8:55pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2024 8:55pm

…er update, and add proper check to delete variant image if present
@aybruhm
Copy link
Member Author

aybruhm commented Oct 11, 2024

The failing CLI command tests are due to the fact that we haven't deployed the backend changes to the cloud production environment, @mmabrouk.

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the quick fix @aybruhm !

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 12, 2024
@mmabrouk mmabrouk merged commit 6c79093 into main Oct 12, 2024
9 of 10 checks passed
@mmabrouk mmabrouk deleted the feature/age-1057-critical-bug-agenta-cli-does-not-work-anymore-post-release branch October 12, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants