Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move templates to backend #2125

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Move templates to backend #2125

merged 7 commits into from
Oct 18, 2024

Conversation

aakrem
Copy link
Collaborator

@aakrem aakrem commented Oct 16, 2024

We want to remove the list of the templates from being hosted in a public s3 bucket as there is no valid reason for having it there. As a result we are moving the list of templates to the backend.
A related PR for commons: https://github.com/Agenta-AI/agenta-commons/pull/122
Issue: https://linear.app/agenta/issue/AGE-1084/

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 2:03pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 2:03pm

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 16, 2024
@dosubot dosubot bot added the Backend label Oct 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 17, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aakrem !
lgtm, but needs to be QA'ed before merge

@aakrem aakrem merged commit c8c61c7 into main Oct 18, 2024
11 checks passed
@aakrem aakrem deleted the move-templates-to-backend branch October 18, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants