Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: Remove Pydantic warnings in CLI #2127

Merged
merged 3 commits into from
Oct 21, 2024
Merged

[Enhancement]: Remove Pydantic warnings in CLI #2127

merged 3 commits into from
Oct 21, 2024

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Oct 17, 2024 •
edited
Loading

Description

This PR removes the Pydantic warnings on the CLI.

Related Issue

Closes AGE-1059.

QA

  • Install the pre-release version of agenta==0.25.4a4
  • Create an app from the CLI
  • Serve the app to either cloud prod, beta or staging (any environment is fine)

Acceptance Tests

  • Verify that there are no CLI warnings on your terminal.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Oct 17, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:10am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:10am

@dosubot dosubot bot added CLI enhancement New feature or request labels Oct 17, 2024
@aybruhm aybruhm requested a review from mmabrouk October 17, 2024 13:46
mmabrouk
mmabrouk approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aybruhm! Can you please pre-release and get someone to QA. Thanks!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 17, 2024
@aybruhm
Copy link
Member Author

aybruhm commented Oct 20, 2024

Thanks @aybruhm! Can you please pre-release and get someone to QA. Thanks!

Done, see thread on Slack.

@mmabrouk mmabrouk merged commit c69f67e into main Oct 21, 2024
9 of 10 checks passed
@mmabrouk mmabrouk deleted the feature/age-1059-remove-warnings-when-using-the-cli branch October 21, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk approved these changes

Assignees
No one assigned
Labels
CLI enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aybruhm @mmabrouk