Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): font style issue #2129

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Conversation

ashrafchowdury
Copy link
Collaborator

Description

This PR aims to fix the font-family issue we have in some of our domains.

Related Issue

Closes AGE-1085

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Oct 18, 2024
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 6:36am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 6:36am

@mmabrouk
Copy link
Member

Thanks @ashrafchowdury do we understand the reason why the fonts stopped working? Did we modify this file and now we are reverting?

@ashrafchowdury
Copy link
Collaborator Author

Thanks @ashrafchowdury do we understand the reason why the fonts stopped working? Did we modify this file and now we are reverting?

We encountered a similar issue on a small scale in the past and resolved it by modifying the code. However, since the current issue is on a much larger scale, we are not going to revert the code. Instead, we are going to improve the code to address the issue.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 21, 2024
@mmabrouk
Copy link
Member

Thanks @ashrafchowdury !

@mmabrouk mmabrouk merged commit 5cbb6a8 into main Oct 21, 2024
9 checks passed
@mmabrouk mmabrouk deleted the fix/application-font-family-issue branch October 21, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antd bug Something isn't working Frontend lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants