Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependency]: Access control in API Keys #2147

Conversation

aybruhm
Copy link
Member

@aybruhm aybruhm commented Oct 23, 2024

This PR contains changes that act as a dependency to https://github.com/Agenta-AI/agenta-commons/pull/124

…scoped to the workspace project when starting variant container in cloud
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:39pm
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 2:39pm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 23, 2024
@mmabrouk
Copy link
Member

End to end tests are failing, it looks like application cannot be created anymore in oss, no?

@aybruhm
Copy link
Member Author

aybruhm commented Oct 23, 2024

End to end tests are failing, it looks like application cannot be created anymore in oss, no?

No, no. It works. I tried earlier and just did, and it still works. I'm not sure why the E2E tests are failing, given that the Backend tests are passing.

@mmabrouk
Copy link
Member

QA'ed in oss and works (tested start_variant by creating a template)

@jp-agenta jp-agenta merged commit 8b9981c into main Nov 5, 2024
11 checks passed
@jp-agenta jp-agenta deleted the feature/age-1139-project-3-scope-api_key-by-project_id-and-keep-the-link-to branch November 5, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants