Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(frontend): add global observability page #2156

Merged
merged 10 commits into from
Nov 4, 2024
Merged

feat(frontend): add global observability page #2156

merged 10 commits into from
Nov 4, 2024

Conversation

ashrafchowdury
Copy link
Collaborator

Description

This PR aims to add a global observability page within the project scope.

Related Issue

Closes AGE-1188

@vercel Vercel
Copy link

vercel bot commented Oct 31, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 11:00am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 11:00am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. feature Frontend labels Oct 31, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 31, 2024
mmabrouk
mmabrouk requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury please see comments in discussion

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Nov 1, 2024
mmabrouk
mmabrouk requested changes Nov 3, 2024
View reviewed changes
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury !
Can you please:

  • Fix the conflicts
  • In traces view (local observability), if I open the filters, I should be able to see a unchangeable filter with app.id is equal the app id

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Nov 4, 2024
@mmabrouk mmabrouk merged commit 393133b into feature/observability-checkpoint-2 Nov 4, 2024
6 checks passed
@mmabrouk mmabrouk deleted the feat/global-observability-page branch November 4, 2024 11:36
@mmabrouk
Copy link
Member

mmabrouk commented Nov 4, 2024

Thanks @ashrafchowdury lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmabrouk mmabrouk mmabrouk requested changes

@bekossy bekossy Awaiting requested review from bekossy

@jp-agenta jp-agenta Awaiting requested review from jp-agenta

Assignees
No one assigned
Labels
feature Frontend size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashrafchowdury @mmabrouk