Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): rearranged observability table columns #2161

Merged

Conversation

ashrafchowdury
Copy link
Collaborator

Description

This PR aims to fix the observability tables columns arrangement for better experience.

Related Issue

Closes AGE-1184

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 7:26am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 7:26am

Copy link
Member

@bekossy bekossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @ashrafchowdury

  • ID column should only display the node id and hidden by default
  • Name should display the node name and icon
  • Usage should be hidden by default

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CleanShot 2024-10-31 at 16 08 18@2x

  1. The name does not need to be a tag
  2. The expand icon and the name should be in the same line (no line break), instead we should show ... if we cannot completely show the name within the column until it is resized

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury lgtm
Can you please fix the conflict. Didn't want to touch it since it seems a minor change in logic happened

@mmabrouk mmabrouk merged commit 75d47dd into feature/observability-checkpoint-2 Nov 4, 2024
6 checks passed
@mmabrouk mmabrouk deleted the fix/observability-table-columns branch November 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend size:M This PR changes 30-99 lines, ignoring generated files. UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants