Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): broken observability windowing logic and format #2234

Conversation

ashrafchowdury
Copy link
Collaborator

Description

This PR aims to fix the broken observability windowing logic, allowing users to select either a start time, an end time, or both. Additionally, it improves the format of the date selection component to match the time format used in the table.

Related Issue

Closes AGE-1267

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 10:13am
agenta-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 10:13am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working Frontend labels Nov 9, 2024
Copy link
Member

@mmabrouk mmabrouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ashrafchowdury
This resolves the issue. There is still a weird issue with the time zone (but that's in a different PR I guess)

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 10, 2024
@mmabrouk mmabrouk merged commit 2c4d080 into feature/observability-checkpoint-2 Nov 10, 2024
6 checks passed
@mmabrouk mmabrouk deleted the fix/observability-sort-filter-logic branch November 10, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants